Coding conventions

// Top-level namespace
namespace SMW;

// Component sub-namespaces (examples)
namespace SMW\SQLStore;
namespace SMW\Elastic;
namespace SMW\SPARQLStore;
namespace SMW\Query;
namespace SMW\DataValues;
namespace SMW\DataItems;
namespace SMW\MediaWiki;   // MediaWiki object accessors live here
namespace SMW\Services;

class ExampleService {

    // 1. public methods first
    public function doSomething(): void {}

    // 2. protected methods second
    protected function doSomethingInternal(): void {}

    // 3. private methods last
    private function helper(): void {}

}

// Preferred — dependencies injected via constructor
class QueryProcessor {

    public function __construct(
        private Store $store,
        private QueryParser $parser,
    ) {}

}

// Avoid — pulling dependencies from a global service locator inside a class
class QueryProcessor {

    public function process( SMWQuery $query ) {
        // Avoid this pattern in non-factory code
        $store = ApplicationFactory::getInstance()->getStore();
    }

}

// Factory: creates one type of object cleanly
class DataItemFactory {

    public function newDIWikiPage( string $dbKey, int $namespace ): DIWikiPage {
        return new DIWikiPage( $dbKey, $namespace );
    }

}

public function getPropertyValues(
    DIWikiPage $subject,
    DIProperty $property,
    ?RequestOptions $requestOptions = null
): array;

/**
 * Returns all values stored for the given property on the given subject.
 *
 * @since 3.0
 *
 * @param DIWikiPage $subject
 * @param DIProperty $property
 *
 * @return DataItem[]
 */
public function getPropertyValues(
    DIWikiPage $subject,
    DIProperty $property
): array;

make composer-test